chia7712 commented on code in PR #17958:
URL: https://github.com/apache/kafka/pull/17958#discussion_r1867631906
##########
clients/src/main/resources/common/message/ConsumerGroupDescribeResponse.json:
##########
@@ -69,7 +70,9 @@
{ "name": "Assignment", "type": "Assignment", "versions": "0+",
"about": "The current assignment." },
{ "name": "TargetAssignment", "type": "Assignment", "versions":
"0+",
- "about": "The target assignment." }
+ "about": "The target assignment." },
+ { "name": "IsClassic", "type": "int8", "versions": "1+",
"default": "-1", "ignorable": true,
Review Comment:
> I prefer to use IsClassic because it's more Intuitive.
I agree that using `IsClassic=false` and `IsClassic=true` would be more
intuitive. However, currently, `IsClassic` can take the values `-1`, `0`, and
`1`. These "magic numbers" are unclear without referring to the documentation.
Additionally, the codebase uses these magic numbers inconsistently across
different classes. For example, several classes such as `ScramMechanism`,
`EndpointType`, `ResourceType`, and `AclOperation` use `0` to represent
"unknown" or "none". `MemberState` use `127` for unknown.
In summary, it seems to me the name `IsClassic` is no longer intuitive after
adopting the int8 type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
