cshannon commented on code in PR #16754: URL: https://github.com/apache/kafka/pull/16754#discussion_r1872222772
########## gradle/spotbugs-exclude.xml: ########## @@ -562,4 +568,10 @@ For a detailed description of spotbugs bug categories, see https://spotbugs.read <Bug pattern="SING_SINGLETON_HAS_NONPRIVATE_CONSTRUCTOR"/> </Match> + <Match> + <!-- DateFormat is not used in more than one thread --> + <Class name="org.apache.kafka.tools.ReplicaVerificationTool$ReplicaBuffer"/> + <Bug pattern="STCAL_INVOKE_ON_STATIC_DATE_FORMAT_INSTANCE"/> Review Comment: I don't remember why I needed to add this because I first worked on this back in July, so I went back to take a look at the file and it looks like I can remove this block entirely because @chia7712 recently added the [same](https://github.com/apache/kafka/blob/0f2a96879030e1ccc575ed10b5cb113efa8200bb/gradle/spotbugs-exclude.xml#L550-L553) exclusion in https://github.com/apache/kafka/pull/17426 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
