cshannon commented on PR #16754: URL: https://github.com/apache/kafka/pull/16754#issuecomment-2529909264
> I re-ran the tests three times, looks good. I'm approving this now, but will wait a few days before merging to see if @gharris1727 or @C0urante (or @chia7712) have anything to add. @mumrah - Sounds good, thanks for the review. I forgot to mention that I looked more into what to do about having to [change](https://github.com/apache/kafka/pull/16754/files#diff-ab24c09f7ecde101419a599c0ee3625a8f180911149a252792490a5618c7dc7cR283) the `DedicatedMirrorIntegrationTest` to prevent a failure because of the Servlet 6 and Jakarta EE10 spec change that no longer allows ambiguous characters anymore in the URL path. If we wanted to restore the previous behavior to allow it, we could [set](https://javadoc.jetty.org/jetty-12/org/eclipse/jetty/server/HttpConfiguration.html#setUriCompliance(org.eclipse.jetty.http.UriCompliance)) the UriComplianceMode to be [LEGACY](https://javadoc.jetty.org/jetty-12/org/eclipse/jetty/http/UriCompliance.html#LEGACY). See this comment: https://github.com/jetty/jetty.project/issues/11890#issuecomment-2156449534 However, I would say it's better to not allow it as the spec now says it's a violation so I think the current change I made is fine, but I guess it depends if there's use cases to allow it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
