m1a2st commented on code in PR #17440:
URL: https://github.com/apache/kafka/pull/17440#discussion_r1873289601


##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/NetworkClientDelegate.java:
##########
@@ -150,7 +155,11 @@ private void maybePropagateMetadataError() {
         try {
             metadata.maybeThrowAnyException();

Review Comment:
   I believe we shouldn't clear the metadata error here because once a metadata 
error is encountered, there might not necessarily be an event to trigger it 
next time. This could result in the metadata error not being propagated. 
Therefore, we should wait until it is thrown before clearing it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to