lianetm commented on code in PR #17440:
URL: https://github.com/apache/kafka/pull/17440#discussion_r1875210056


##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/NetworkClientDelegate.java:
##########
@@ -150,7 +155,11 @@ private void maybePropagateMetadataError() {
         try {
             metadata.maybeThrowAnyException();

Review Comment:
   ok, we're saying it gets cleared as soon as it's propagated (to ensure that 
it's indeed propagated), and we could still get an exception from a previously 
sent request (this was my concern). Anyways that's actually what we have with 
the classic consumer, so it's consistent (there are actually tests specifically 
covering the behaviour considering that). 
   
https://github.com/apache/kafka/blob/ee4264439ddda7bdebcaa845752b824abba14161/core/src/test/scala/integration/kafka/api/EndToEndAuthorizationTest.scala#L553-L554
  
   
   Ok with me, I wonder if there something we could improve there for both but 
no need to block this as it's the current behaviour. I'll file a jira if I come 
up with clear thoughts about it. Thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to