KApolinario1120 commented on code in PR #17973:
URL: https://github.com/apache/kafka/pull/17973#discussion_r1877164922
##########
streams/src/main/java/org/apache/kafka/streams/kstream/Consumed.java:
##########
@@ -96,13 +112,21 @@ protected Consumed(final Consumed<K, V> consumed) {
*
* @return a new instance of {@link Consumed}
*/
+ @Deprecated
public static <K, V> Consumed<K, V> with(final Serde<K> keySerde,
final Serde<V> valueSerde,
final TimestampExtractor
timestampExtractor,
final Topology.AutoOffsetReset
resetPolicy) {
return new Consumed<>(keySerde, valueSerde, timestampExtractor,
resetPolicy, null);
}
+ public static <K, V> Consumed<K, V> with(final Serde<K> keySerde,
+ final Serde<V> valueSerde,
+ final TimestampExtractor
timestampExtractor,
+ final AutoOffsetReset
resetPolicy) {
+ return new Consumed<>(keySerde, valueSerde, timestampExtractor,
resetPolicy, null);
Review Comment:
Updated the Consumed methods to the best of my understanding.. I am not
feeling confident that I made the change you were after. We are adding a helper
function to be able to pass the legacy version as the new one to satisfy the
refactored constructor, right? Was it appropriate to pass it twice for the
legacy reset policy methods, and once for the methods that use the new one?
Please double check me on this and I will change it if needed, I think I've
committed what you were after here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
