KApolinario1120 commented on code in PR #17973:
URL: https://github.com/apache/kafka/pull/17973#discussion_r1878085081
##########
streams/src/main/java/org/apache/kafka/streams/kstream/Consumed.java:
##########
@@ -70,6 +74,18 @@ private Consumed(final Serde<K> keySerde,
this.processorName = processorName;
}
+ private Consumed(final Serde<K> keySerde,
Review Comment:
added this, thank you
##########
streams/src/main/java/org/apache/kafka/streams/kstream/Consumed.java:
##########
@@ -96,13 +112,21 @@ protected Consumed(final Consumed<K, V> consumed) {
*
* @return a new instance of {@link Consumed}
*/
+ @Deprecated
public static <K, V> Consumed<K, V> with(final Serde<K> keySerde,
final Serde<V> valueSerde,
final TimestampExtractor
timestampExtractor,
final Topology.AutoOffsetReset
resetPolicy) {
return new Consumed<>(keySerde, valueSerde, timestampExtractor,
resetPolicy, null);
}
+ public static <K, V> Consumed<K, V> with(final Serde<K> keySerde,
Review Comment:
Added docs to all, thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
