AndrewJSchofield commented on code in PR #18112:
URL: https://github.com/apache/kafka/pull/18112#discussion_r1877686289


##########
docs/upgrade.html:
##########
@@ -159,6 +159,9 @@ <h5><a id="upgrade_400_notable" 
href="#upgrade_400_notable">Notable changes in 4
                         </li>
                         <li>The deprecated 
<code>sendOffsetsToTransaction(Map&lt;TopicPartition, OffsetAndMetadata&gt;, 
String)</code> method has been removed from the Producer API.
                         </li>
+                        <li>The <code>flush</code> method now detects 
potential deadlocks and logs a warning when used inside a callback.

Review Comment:
   Personally, I tend the other way on this. If someone is now getting errors 
logged, this explains why. No big deal either way, I suppose. Just my 2 cents.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to