wernerdv commented on code in PR #18074:
URL: https://github.com/apache/kafka/pull/18074#discussion_r1878126345
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ExactlyOnceWorkerSourceTask.java:
##########
@@ -321,7 +321,7 @@ private void commitTransaction() {
error = flushError.get();
if (error != null) {
- recordCommitFailure(time.milliseconds() - started, null);
+ recordCommitFailure(time.milliseconds() - started);
Review Comment:
I'm sorry I don't understand what the behavioral change is.
In trunk:
```
protected void recordCommitFailure(long duration, Throwable error) {
taskMetricsGroup.recordCommit(duration, false, error);
}
void recordCommit(long duration, boolean success, Throwable error) {
if (success) {
commitTime.record(duration);
commitAttempts.record(1.0d);
} else {
commitAttempts.record(0.0d);
}
}
```
In current brunch:
```
protected void recordCommitFailure(long duration) {
taskMetricsGroup.recordCommit(duration, false);
}
void recordCommit(long duration, boolean success) {
if (success) {
commitTime.record(duration);
commitAttempts.record(1.0d);
} else {
commitAttempts.record(0.0d);
}
}
```
I only removed the `Throwable error` argument since it was not used inside
the `recordCommit()` method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
