mimaison commented on code in PR #18074:
URL: https://github.com/apache/kafka/pull/18074#discussion_r1878135858


##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ExactlyOnceWorkerSourceTask.java:
##########
@@ -321,7 +321,7 @@ private void commitTransaction() {
 
         error = flushError.get();
         if (error != null) {
-            recordCommitFailure(time.milliseconds() - started, null);
+            recordCommitFailure(time.milliseconds() - started);

Review Comment:
   My bad, I only took a quick look and got confused with 
`recordCommitSuccess()`. You're right the `Throwable` argument can be removed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to