jolshan commented on code in PR #18132:
URL: https://github.com/apache/kafka/pull/18132#discussion_r1880743001
##########
metadata/src/main/java/org/apache/kafka/controller/QuorumFeatures.java:
##########
@@ -63,7 +63,7 @@ public static Map<String, VersionRange>
defaultFeatureMap(boolean enableUnstable
MetadataVersion.latestTesting().featureLevel() :
MetadataVersion.latestProduction().featureLevel()));
for (Feature feature : Feature.PRODUCTION_FEATURES) {
- short maxVersion = enableUnstable ? feature.latestTesting() :
feature.latestProduction();
+ short maxVersion = enableUnstable ? feature.latestTesting() :
feature.defaultLevel(MetadataVersion.LATEST_PRODUCTION);
Review Comment:
@junrao @dongnuo123 I noticed we didn't change the defaults here on the
previous PR. I have done so here. A test was failing since the production
version for transaction version is now not the same as the default based on the
latest production MV.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
