jolshan commented on code in PR #18132:
URL: https://github.com/apache/kafka/pull/18132#discussion_r1881077495
##########
metadata/src/main/java/org/apache/kafka/controller/QuorumFeatures.java:
##########
@@ -63,7 +63,7 @@ public static Map<String, VersionRange>
defaultFeatureMap(boolean enableUnstable
MetadataVersion.latestTesting().featureLevel() :
MetadataVersion.latestProduction().featureLevel()));
for (Feature feature : Feature.PRODUCTION_FEATURES) {
- short maxVersion = enableUnstable ? feature.latestTesting() :
feature.latestProduction();
+ short maxVersion = enableUnstable ? feature.latestTesting() :
feature.defaultLevel(MetadataVersion.LATEST_PRODUCTION);
Review Comment:
Yes. My understanding from https://github.com/apache/kafka/pull/17886 was
that we want a separate production vs default value.
I thought these methods were also meant to create the default features, not
the max supported ones. It's my bad if I misunderstood that. I will take
another look and if that is the case, fix the test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
