mjsax commented on code in PR #18154: URL: https://github.com/apache/kafka/pull/18154#discussion_r1881321880
########## streams/src/test/java/org/apache/kafka/streams/processor/internals/ProcessorTopologyTest.java: ########## @@ -109,8 +110,8 @@ public void setup() { // Create a new directory in which we'll put all of the state for this test, enabling running tests in parallel ... final File localState = TestUtils.tempDirectory(); props.setProperty(StreamsConfig.STATE_DIR_CONFIG, localState.getAbsolutePath()); - props.setProperty(StreamsConfig.DEFAULT_KEY_SERDE_CLASS_CONFIG, Serdes.String().getClass().getName()); - props.setProperty(StreamsConfig.DEFAULT_VALUE_SERDE_CLASS_CONFIG, Serdes.String().getClass().getName()); + props.setProperty(StreamsConfig.DEFAULT_KEY_SERDE_CLASS_CONFIG, Serdes.StringSerde.class.getName()); + props.setProperty(StreamsConfig.DEFAULT_VALUE_SERDE_CLASS_CONFIG, Serdes.StringSerde.class.getName()); Review Comment: Side cleanup to get rid of some IntelliJ warning. (also cleaner code. Similar stuff below. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org