mjsax commented on code in PR #18154:
URL: https://github.com/apache/kafka/pull/18154#discussion_r1881324545
##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/ProcessorTopologyTest.java:
##########
@@ -1775,30 +1286,9 @@ public void process(final Record<String, String> record)
{
}
}
- @SuppressWarnings("deprecation") // Old PAPI. Needs to be migrated.
- private <K, V> org.apache.kafka.streams.processor.ProcessorSupplier<K, V>
define(final org.apache.kafka.streams.processor.Processor<K, V> processor) {
- return () -> processor;
- }
-
- @SuppressWarnings("deprecation") // Old PAPI. Needs to be migrated.
- private <K, V> org.apache.kafka.streams.processor.ProcessorSupplier<K, V>
defineWithStoresOldAPI(final
Supplier<org.apache.kafka.streams.processor.Processor<K, V>> supplier,
Review Comment:
There is already `defineWithStores()` for new PAPI -- nothing to be migrated
-- deleting
##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/ProcessorTopologyTest.java:
##########
@@ -1775,30 +1286,9 @@ public void process(final Record<String, String> record)
{
}
}
- @SuppressWarnings("deprecation") // Old PAPI. Needs to be migrated.
- private <K, V> org.apache.kafka.streams.processor.ProcessorSupplier<K, V>
define(final org.apache.kafka.streams.processor.Processor<K, V> processor) {
- return () -> processor;
- }
-
- @SuppressWarnings("deprecation") // Old PAPI. Needs to be migrated.
- private <K, V> org.apache.kafka.streams.processor.ProcessorSupplier<K, V>
defineWithStoresOldAPI(final
Supplier<org.apache.kafka.streams.processor.Processor<K, V>> supplier,
-
final Set<StoreBuilder<?>> stores) {
- return new org.apache.kafka.streams.processor.ProcessorSupplier<K,
V>() {
- @Override
- public org.apache.kafka.streams.processor.Processor<K, V> get() {
- return supplier.get();
- }
-
- @Override
- public Set<StoreBuilder<?>> stores() {
- return stores;
- }
- };
- }
-
private <KIn, VIn, KOut, VOut> ProcessorSupplier<KIn, VIn, KOut, VOut>
defineWithStores(final Supplier<Processor<KIn, VIn, KOut, VOut>> supplier,
final Set<StoreBuilder<?>> stores) {
- return new ProcessorSupplier<KIn, VIn, KOut, VOut>() {
+ return new ProcessorSupplier<>() {
Review Comment:
side cleanup
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
