AndrewJSchofield commented on code in PR #18101:
URL: https://github.com/apache/kafka/pull/18101#discussion_r1882196291
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareHeartbeatRequestManager.java:
##########
@@ -205,4 +208,25 @@ void reset() {
}
}
}
+
Review Comment:
Please could we have the `InheritDoc` annotation as for the other methods.
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareHeartbeatRequestManager.java:
##########
@@ -205,4 +208,25 @@ void reset() {
}
}
}
+
+ @Override
Review Comment:
Please move this method earlier in the class, just after the constructors so
the layout matches `ConsumerHeartbeatRequestManager`. This makes it easier for
us to keep them in step over time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
