lianetm commented on code in PR #18101:
URL: https://github.com/apache/kafka/pull/18101#discussion_r1884366119
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ShareHeartbeatRequestManagerTest.java:
##########
@@ -422,6 +425,29 @@ public void testHeartbeatResponseOnErrorHandling(final
Errors error, final boole
}
}
+ @ParameterizedTest
+ @ValueSource(strings = {SHARE_PROTOCOL_NOT_SUPPORTED_MSG})
+ public void testUnsupportedVersion(String errorMsg) {
Review Comment:
this is truly `testUnsupportedVersionGeneratedOnTheClient` (client response
with exception). Renaming will maybe clarify, and we should ensure we have
coverage for something like `testUnsupportedVersionGeneratedOnTheBroker`
(client response with `ErrorCode`), is it already covered?
The outcome of both tests should be the same, but they execute diff code
paths modified in this PR (handleSpecificError and
handleSpecificFailure/exception)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
