OmniaGM commented on code in PR #15968:
URL: https://github.com/apache/kafka/pull/15968#discussion_r1884160169
##########
core/src/main/scala/kafka/server/ReplicaManager.scala:
##########
@@ -788,7 +814,9 @@ class ReplicaManager(val config: KafkaConfig,
* @param requiredAcks number of replicas who must
acknowledge the append before sending the response
* @param internalTopicsAllowed boolean indicating whether internal
topics can be appended to
* @param origin source of the append request (ie,
client, replication, coordinator)
- * @param entriesPerPartition the records per partition to be
appended
+ * @param entriesPerPartition the records per topic partition to
be appended.
+ * If topic partition contains
Uuid.ZERO_UUID or null as topicId the method
Review Comment:
You are right, It never will be null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
