m1a2st commented on code in PR #18166:
URL: https://github.com/apache/kafka/pull/18166#discussion_r1885528522
##########
core/src/test/scala/integration/kafka/api/BaseProducerSendTest.scala:
##########
@@ -55,7 +55,7 @@ abstract class BaseProducerSendTest extends
KafkaServerTestHarness {
overridingProps.put(ServerLogConfigs.NUM_PARTITIONS_CONFIG, 4.toString)
TestUtils.createBrokerConfigs(
numServers,
- zkConnectOrNull,
+ null,
Review Comment:
Some tests are still using not `null` value on this method.
https://github.com/apache/kafka/blob/ed10fc63a9fd3032a529f7e10a0f863ee71b710a/core/src/test/scala/unit/kafka/server/ReplicaAlterLogDirsThreadTest.scala#L208
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
