m1a2st commented on code in PR #18166:
URL: https://github.com/apache/kafka/pull/18166#discussion_r1886713767
##########
core/src/test/scala/integration/kafka/server/QuorumTestHarness.scala:
##########
@@ -482,18 +365,6 @@ abstract class QuorumTestHarness extends Logging {
Configuration.setConfiguration(null)
faultHandler.maybeRethrowFirstException()
}
-
- // Trigger session expiry by reusing the session id in another client
- def createZooKeeperClientToTriggerSessionExpiry(zooKeeper: ZooKeeper):
ZooKeeper = {
- val dummyWatcher = new Watcher {
- override def process(event: WatchedEvent): Unit = {}
- }
- val anotherZkClient = new ZooKeeper(zkConnect, 1000, dummyWatcher,
- zooKeeper.getSessionId,
- zooKeeper.getSessionPasswd)
- assertNull(anotherZkClient.exists("/nonexistent", false)) // Make sure new
client works
- anotherZkClient
- }
}
object QuorumTestHarness {
Review Comment:
It still use on this, but I think we can remove it
https://github.com/apache/kafka/blob/220c57852100e895b460e56d1132a3c9239aaa59/core/src/test/scala/integration/kafka/server/QuorumTestHarness.scala#L530
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
