swikarpat opened a new pull request, #18275:
URL: https://github.com/apache/kafka/pull/18275

   Upgrades RocksDB to version 9.7.3 to address 
[KAFKA-15443](https://issues.apache.org/jira/browse/KAFKA-15443)
   
   This PR addresses the following compatibility issues introduced by the 
RocksDB upgrade:
   
   *   **Removal of `AccessHint`:** The `AccessHint` class was completely 
removed in RocksDB 9.7.3. This required removing all import statements, 
variable declarations, method parameters, method return types, and static 
method calls related to `AccessHint` in 
`RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapter.java 
`RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapterTest.java.
   
   *   **Removal of `NO_FILE_CLOSES`:** The `NO_FILE_CLOSES` metric was also 
removed in RocksDB 9.7.3. The calculation for `numberOfOpenFiles` in 
`RocksDBMetricsRecorder.java` has been adjusted to now track the total number 
of file opens since the last reset. The previous calculation, which subtracted 
`NO_FILE_CLOSES` from `NO_FILE_OPENS`, is no longer possible.
   The reason RocksDB team removed NO_FILE_CLOSES it seems to me they detected 
not properly working: 
https://github.com/search?q=repo%3Afacebook%2Frocksdb+NO_FILE_CLOSES&type=issues
   
   Any feedback or any proposed changes you would like me to do are welcome let 
me know.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to