swikarpat commented on code in PR #18275:
URL: https://github.com/apache/kafka/pull/18275#discussion_r1893486345
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapter.java:
##########
@@ -842,12 +830,6 @@ public Options setSstFileManager(final SstFileManager
sstFileManager) {
return this;
}
- @Override
- public Options setLogger(final org.rocksdb.Logger logger) {
- dbOptions.setLogger(logger);
Review Comment:
@mjsax thanks for feedback. I wanted to confirm setLogger() method.
Parameter inside setLogger() has changed to LoggerInterface. I've made
corrections and put method back in that java class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
