mumrah commented on code in PR #18299:
URL: https://github.com/apache/kafka/pull/18299#discussion_r1895818795
##########
build.gradle:
##########
@@ -1328,6 +1328,43 @@ project(':core') {
duplicatesStrategy 'exclude'
}
+ task libLicenseCheck(dependsOn: 'releaseTarGz', type: Copy) {
Review Comment:
I think it would be better to do this as part of releaseTarGz so we can't
mistakenly produce an artifact that is missing licenses. I glanced through
build.gradle and I don't see where we're gathering the libraries into the
LICENSE file. Do you know where that happens?
##########
.github/workflows/build.yml:
##########
@@ -143,6 +143,9 @@ jobs:
find ./site-docs/generated -type f -exec grep -L "." {} \; >&2
exit 1
fi
+ - name: Check missing lib license
+ run: |
+ ./gradlew libLicenseCheck
Review Comment:
Can you add this to the previous `gradlew` invocation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
