xijiu commented on code in PR #18299:
URL: https://github.com/apache/kafka/pull/18299#discussion_r1897535052


##########
build.gradle:
##########
@@ -1328,6 +1328,43 @@ project(':core') {
     duplicatesStrategy 'exclude'
   }
 
+  task libLicenseCheck(dependsOn: 'releaseTarGz', type: Copy) {

Review Comment:
   hi David, do you mean where we replace the content of LICENSE with the 
content of LICENSE-binary ? 
   If that's the case, I think it should be below:
   `from "$rootDir/NOTICE-binary" rename {String filename -> 
filename.replace("-binary", "")}`  in the releaseTarGz task
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to