m1a2st commented on code in PR #18196:
URL: https://github.com/apache/kafka/pull/18196#discussion_r1900171523
##########
core/src/main/scala/kafka/server/metadata/DynamicClientQuotaPublisher.scala:
##########
@@ -48,6 +51,11 @@ class DynamicClientQuotaPublisher(
): Unit = {
val deltaName = s"MetadataDelta up to
${newImage.highestOffsetAndEpoch().offset}"
try {
+ val clientQuotaCallback =
conf.getConfiguredInstance(QuotaConfig.CLIENT_QUOTA_CALLBACK_CLASS_CONFIG,
classOf[ClientQuotaCallback])
+ if (clientQuotaCallback != null) {
Review Comment:
And
[client.quota.callback.class](https://kafka.apache.org/documentation/#brokerconfigs_client.quota.callback.class)
this config can setting
`kafka.server.ClientQuotaManager#DefaultQuotaCallback`?
I think DefaultQuotaCallback the main function is setting the default value,
not execute the callback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
