TaiJuWu commented on code in PR #18196:
URL: https://github.com/apache/kafka/pull/18196#discussion_r1900335723
##########
core/src/main/scala/kafka/server/metadata/DynamicClientQuotaPublisher.scala:
##########
@@ -48,6 +51,11 @@ class DynamicClientQuotaPublisher(
): Unit = {
val deltaName = s"MetadataDelta up to
${newImage.highestOffsetAndEpoch().offset}"
try {
+ val clientQuotaCallback =
conf.getConfiguredInstance(QuotaConfig.CLIENT_QUOTA_CALLBACK_CLASS_CONFIG,
classOf[ClientQuotaCallback])
+ if (clientQuotaCallback != null) {
Review Comment:
I got your point. You are right, thanks!
I misunderstand this will check the instance of `quotaCallback` in
`ClientQuotaManager` but it actually checks this callback base on configuration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
