frankvicky commented on PR #18218: URL: https://github.com/apache/kafka/pull/18218#issuecomment-2569012455
Hi @ijuma, I noticed a discrepancy between this PR and [KIP-896](https://cwiki.apache.org/confluence/x/K5sODg) regarding `DeleteGroups` support: ``` DeleteGroups: none due to clients (Sarama) support - V0 per the baseline * librdkafka: [V1](https://github.com/confluentinc/librdkafka/blob/v1.8.2/src/rdkafka_request.c#L4147) * KafkaJS: [V1](https://github.com/tulios/kafkajs/blob/v1.15.0/src/protocol/requests/deleteGroups/v1/request.js#L7) * Sarama: [V0](https://github.com/Shopify/sarama/blob/v1.29.1/describe_groups_request.go#L21) * kafka-python: [V1](https://github.com/dpkp/kafka-python/blob/2.0.2/kafka/admin/client.py#L1328) ``` According to the KIP, Sarama only supports V0 of the `DeleteGroups RPC`. However, I found issue (https://github.com/IBM/sarama/issues/2408) which suggests Sarama will upgrade its RPC support. (And it has support v1 after https://github.com/IBM/sarama/pull/2551) If this is the case, should we update the description in KIP-896 (https://cwiki.apache.org/confluence/x/K5sODg)? WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
