ijuma commented on code in PR #18218:
URL: https://github.com/apache/kafka/pull/18218#discussion_r1890791622
##########
clients/src/test/java/org/apache/kafka/common/requests/RequestResponseTest.java:
##########
@@ -379,7 +378,7 @@ public void testSerializationSpecialCases() {
checkResponse(createFetchResponse(Errors.FETCH_SESSION_ID_NOT_FOUND,
123), (short) 7);
checkOlderFetchVersions();
// Metadata
- checkRequest(MetadataRequest.Builder.allTopics().build((short) 2));
+ checkRequest(MetadataRequest.Builder.allTopics().build((short) 4));
//FIXME Does version 4 have the special cases?
Review Comment:
I am going through the FIXMEs and will push a commit with the fixes soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
