chia7712 commented on code in PR #18384:
URL: https://github.com/apache/kafka/pull/18384#discussion_r1903118819
##########
core/src/main/scala/kafka/server/DynamicBrokerConfig.scala:
##########
@@ -1068,8 +1059,7 @@ class DynamicListenerConfig(server: KafkaBroker) extends
BrokerReconfigurable wi
listenersToMap(newConfig.effectiveAdvertisedBrokerListeners))) {
verifyListenerRegistrationAlterationSupported()
server match {
- case kafkaServer: KafkaServer =>
kafkaServer.kafkaController.updateBrokerInfo(kafkaServer.createBrokerInfo)
- case _ => throw new RuntimeException("Unable to handle
non-kafkaServer")
+ case _ => throw new RuntimeException("Unable to handle reconfigure")
Review Comment:
We should remove `SocketServerConfigs.ADVERTISED_LISTENERS_CONFIG` from
`ReconfigurableConfigs` as well.
https://github.com/apache/kafka/blob/a628d9bc4d82ddb63ca00f7bcd88a6a6788eae7f/core/src/main/scala/kafka/server/DynamicBrokerConfig.scala#L912
That can disallow users to configure advertised listeners dynamically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
