m1a2st commented on code in PR #18384:
URL: https://github.com/apache/kafka/pull/18384#discussion_r1903274913
##########
core/src/main/scala/kafka/server/DynamicBrokerConfig.scala:
##########
@@ -1068,8 +1059,7 @@ class DynamicListenerConfig(server: KafkaBroker) extends
BrokerReconfigurable wi
listenersToMap(newConfig.effectiveAdvertisedBrokerListeners))) {
verifyListenerRegistrationAlterationSupported()
server match {
- case kafkaServer: KafkaServer =>
kafkaServer.kafkaController.updateBrokerInfo(kafkaServer.createBrokerInfo)
- case _ => throw new RuntimeException("Unable to handle
non-kafkaServer")
+ case _ => throw new RuntimeException("Unable to handle reconfigure")
Review Comment:
I open a Jira to test all dynamic config which can't dynamic configure in
Kraft, and only find `ADVERTISED_LISTENERS_CONFIG` can't, If we addressed it on
this PR, I will close [Jira](https://issues.apache.org/jira/browse/KAFKA-18403)
and https://github.com/apache/kafka/pull/18390
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
