bmscomp commented on code in PR #13627:
URL: https://github.com/apache/kafka/pull/13627#discussion_r1903352310
##########
clients/src/main/java/org/apache/kafka/common/Uuid.java:
##########
@@ -151,19 +151,22 @@ private byte[] getBytesFromUuid() {
return uuidBytes.array();
}
+ /**
+ * Compares this Uuid with another given Uuid.
+ * <p>
+ * This implementation is taken from the compareTo method of the official
java.util.UUID implementation.
Review Comment:
@ijuma We just called it openJDK implementation it's not specific to open
JDK since it's a recent one it's just about a way of comparison mean the
compareTo, the same question can be asked when it comes to implement equals and
hashCode for example every developer is getting inspired by the openJDK
reference implementation
@divijvaidya What are your thoughts ? I think we have a nice topic right
here on reference implementations and also Licences
May be we have to add an entry on LICENCES file as we are using other
libraries are referencing them
I agree it's a very good question @ijuma
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
