ijuma commented on code in PR #13627:
URL: https://github.com/apache/kafka/pull/13627#discussion_r1903354618
##########
clients/src/main/java/org/apache/kafka/common/Uuid.java:
##########
@@ -151,19 +151,22 @@ private byte[] getBytesFromUuid() {
return uuidBytes.array();
}
+ /**
+ * Compares this Uuid with another given Uuid.
+ * <p>
+ * This implementation is taken from the compareTo method of the official
java.util.UUID implementation.
Review Comment:
> May be we have to add an entry on LICENCES file as we are using other
libraries are referencing them
That's only allowed when the license is compatible - OpenJDK's license is
not.
> the same question can be asked when it comes to implement equals and
hashCode for example every developer is getting inspired by the openJDK
reference implementation
Please check https://github.com/apache/kafka/blob/trunk/CONTRIBUTING.md. It
states clearly that you can only contribute your own work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
