chia7712 commented on code in PR #17671:
URL: https://github.com/apache/kafka/pull/17671#discussion_r1905589260
##########
test-common/src/main/java/org/apache/kafka/common/test/KafkaClusterTestKit.java:
##########
@@ -176,6 +179,15 @@ private KafkaConfig createNodeConfig(TestKitNode node)
throws IOException {
// reduce log cleaner offset map memory usage
props.putIfAbsent(CleanerConfig.LOG_CLEANER_DEDUPE_BUFFER_SIZE_PROP, "2097152");
+ if
(brokerSecurityProtocol.equals(SecurityProtocol.SASL_PLAINTEXT.name)) {
Review Comment:
it seems we set security for both controller and broker based on the
`brokerSecurityProtocol`, right? if so, that is weird to me as we totally
ignore `controllerSecurityProtocol` ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
