divijvaidya commented on code in PR #18094:
URL: https://github.com/apache/kafka/pull/18094#discussion_r1905940530
##########
raft/src/main/java/org/apache/kafka/raft/SegmentPosition.java:
##########
@@ -14,10 +14,12 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-package kafka.raft
+package org.apache.kafka.raft;
-import org.apache.kafka.raft.OffsetMetadata
+public record SegmentPosition(long baseOffset, int relativePosition)
implements OffsetMetadata {
Review Comment:
IMO both SegmentPosition and OffsetMetadata should be in storage layer.
Ideally, layers above UnifiedLog should not know that there is a concept of
segment which is used to physically store data.
Happy to punt this to a different PR for later so that we can at least start
with conversion of scala to java here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
