mimaison commented on code in PR #18094:
URL: https://github.com/apache/kafka/pull/18094#discussion_r1905963860


##########
raft/src/main/java/org/apache/kafka/raft/SegmentPosition.java:
##########
@@ -14,10 +14,12 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-package kafka.raft
+package org.apache.kafka.raft;
 
-import org.apache.kafka.raft.OffsetMetadata
+public record SegmentPosition(long baseOffset, int relativePosition) 
implements OffsetMetadata {

Review Comment:
   I understand your point. Today the raft module does not depend on storage. 
However this will likely change when we'll want to migrate the remaining raft 
classes out of core (`KafkaRaftManager`/`KafkaMetadataLog`). 
   
   Let's first do the conversion then we can reconsider where to move classes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to