squah-confluent commented on code in PR #18224:
URL: https://github.com/apache/kafka/pull/18224#discussion_r1907918895
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -6091,30 +6096,41 @@ private CoordinatorResult<LeaveGroupResponseData,
CoordinatorRecord> classicGrou
}
}
- if (!records.isEmpty()) {
- // Check whether resolved regular expressions could be deleted.
- Set<String> deletedRegexes = maybeDeleteResolvedRegularExpressions(
- records,
- group,
- validLeaveGroupMembers
- );
+ List<CoordinatorRecord> records = new ArrayList<>();
+ if (!validLeaveGroupMembers.isEmpty()) {
+ if (validateOnlineDowngradeWithFencedMembers(group,
validLeaveGroupMemberIds)) {
Review Comment:
That works well and dedupes some code.
`maybeDeleteResolvedRegularExpression` is no longer used so can be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
