squah-confluent commented on code in PR #18224:
URL: https://github.com/apache/kafka/pull/18224#discussion_r1907929701
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/classic/ClassicGroup.java:
##########
@@ -1336,21 +1336,21 @@ public Map<String, byte[]> groupAssignment() {
/**
* Convert the given ConsumerGroup to a corresponding ClassicGroup.
- * The member with leavingMemberId will not be converted to the new
ClassicGroup as it's the last
- * member using new consumer protocol that left and triggered the
downgrade.
*
* @param consumerGroup The converted ConsumerGroup.
- * @param leavingMemberId The member that will not be
converted in the ClassicGroup.
- * @param joiningMember The member that needs to be
converted and added to the ClassicGroup.
+ * @param leavingMemberIds The members that will not be
converted in the ClassicGroup.
+ * @param replacedMemberId The member that will be replaced
by replacingMember in the ClassicGroup.
Review Comment:
I've reverted the new parameter. I'm not really happy with either approach
to be honest. There are two different reasons we might want to downgrade a
group and it makes for an awkward method signature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
