ppkarwasz commented on PR #18472: URL: https://github.com/apache/kafka/pull/18472#issuecomment-2582978621
> Additionally, `jackson-dataformat-yaml` can be removed from runtime dependency too. +1 > Maybe `log4j-core` and `log4j-api` can be moved to `compileOnly` and then include them into distribution? Gradle apparently has a feature for that, see [Optional dependencies are not optional](https://blog.gradle.org/optional-dependencies). With a snippet like: ```groovy java { registerFeature('loggingConfig') { usingSourceSet(sourceSets.main) } } ``` it should be possible to: - declare `log4j-core` as a [optional Maven dependency](https://maven.apache.org/guides/introduction/introduction-to-optional-and-excludes-dependencies.html) with a scope of `runtime`. - Gradle users will still be able to make import the transitive dependency using: ```groovy implementation("org.apache.kafka:kafka_2_13") { capabilities { requireCapability("org.apache.kafka:kafka_2_13-logging-config") } } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
