ppkarwasz commented on PR #18472: URL: https://github.com/apache/kafka/pull/18472#issuecomment-2585756769
> @ppkarwasz we don't use the Gradle’s feature variants in this PR due to following reasons. > > 1. We do not expect users to include the optional dependencies. Instead, users should explicitly add their preferred SLF4j provider (including the specific version) to their project dependencies. If they also include a Log4j provider, they will need to resolve any potential conflicts. > > 2. Utilizing `configurations.releaseOnly` can effectively add the necessary Log4j 2 dependencies to the classpath for end-to-end tests and scripts. The PR looks good to me now. For a POM file having `log4j-core` as an **optional** runtime dependency or not having it at all is pretty much a matter of taste. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
