TaiJuWu commented on code in PR #18432:
URL: https://github.com/apache/kafka/pull/18432#discussion_r1913134917
##########
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##########
@@ -485,44 +412,6 @@ class KafkaApisTest extends Logging {
}
}
- @Test
- def testAlterConfigsWithAuthorizer(): Unit = {
Review Comment:
> > but this should be another issue and we can make it as follow ups.
>
> Pardon me, what is "another issue"? There is no extra authorisation for
`AlterConfigsRequest` as it does not support to change logger. It seems to me
the follow-up for this unit test is to add checks for `configManager.preprocess`
Oh, sorry. I think this again.
All `alterConfig` (no matter incremental or not ) should forward to
controller directly so there is no follow up.
Previous image (from mine), we can do some authorize here but no matter what
we always need to send to controller.
There is no optimism space.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
