TaiJuWu commented on code in PR #18432:
URL: https://github.com/apache/kafka/pull/18432#discussion_r1913065969
##########
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##########
@@ -485,44 +412,6 @@ class KafkaApisTest extends Logging {
}
}
- @Test
- def testAlterConfigsWithAuthorizer(): Unit = {
Review Comment:
> we used to do authorisation in two places (once on the broker and once at
the controller)
Sorry for unclarification, for `IncrementalAlterConfig` we authorize
`BORKER_LOGGER` only [1], which apply to locally and it does not send to
controller, other requests we do other authorization on controller.
`BORKER_LOGGER` does not support for `AlterConfig` [2] so we don't do any
authorization here.
[1]
https://github.com/apache/kafka/blob/bbdf79e1b4ffd4960f42ec128edbced11349c538/core/src/main/scala/kafka/server/ConfigAdminManager.scala#L137-L155
[2]
https://github.com/apache/kafka/blob/cbbeccad632d37c131bfa494fdb2eabc5df7610d/core/src/main/scala/kafka/server/KafkaApis.scala#L2385-L2386
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
