apoorvmittal10 commented on code in PR #18459:
URL: https://github.com/apache/kafka/pull/18459#discussion_r1913284564
##########
core/src/test/java/kafka/server/share/SharePartitionManagerTest.java:
##########
@@ -146,6 +146,7 @@ public class SharePartitionManagerTest {
private static final short MAX_FETCH_RECORDS = 500;
private static final int DELAYED_SHARE_FETCH_MAX_WAIT_MS = 2000;
private static final int DELAYED_SHARE_FETCH_TIMEOUT_MS = 3000;
+ private static final int BATCH_SIZE = 500;
Review Comment:
I don't think it's necessary to do that in tests, it could be for individual
classes itself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
