AndrewJSchofield commented on code in PR #18459: URL: https://github.com/apache/kafka/pull/18459#discussion_r1914658017
########## core/src/main/java/kafka/server/share/SharePartition.java: ########## @@ -1176,11 +1176,12 @@ private boolean initializedOrThrowException() { }; } - private AcquiredRecords acquireNewBatchRecords( + private ShareAcquiredRecords acquireNewBatchRecords( String memberId, Iterable<? extends RecordBatch> batches, long firstOffset, long lastOffset, + int batchSize, Review Comment: Yes. That's it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org