kirktrue commented on code in PR #18532:
URL: https://github.com/apache/kafka/pull/18532#discussion_r1920912620
##########
core/src/test/scala/integration/kafka/api/ConsumerBounceTest.scala:
##########
@@ -59,7 +59,12 @@ class ConsumerBounceTest extends AbstractConsumerTest with
Logging {
GroupCoordinatorConfig.OFFSETS_TOPIC_PARTITIONS_CONFIG -> "1",
GroupCoordinatorConfig.GROUP_MIN_SESSION_TIMEOUT_MS_CONFIG -> "10", // set
small enough session timeout
GroupCoordinatorConfig.GROUP_INITIAL_REBALANCE_DELAY_MS_CONFIG -> "0",
+
+ // Tests will run for CONSUMER and CLASSIC group protocol, so set the
group max size property
+ // required for each.
+ GroupCoordinatorConfig.CONSUMER_GROUP_MAX_SIZE_CONFIG ->
maxGroupSize.toString,
GroupCoordinatorConfig.GROUP_MAX_SIZE_CONFIG -> maxGroupSize.toString,
+
Review Comment:
Nit: extra newline?
##########
core/src/test/scala/integration/kafka/api/ConsumerBounceTest.scala:
##########
@@ -297,12 +302,15 @@ class ConsumerBounceTest extends AbstractConsumerTest
with Logging {
* there is no coordinator, but close should timeout and return. If close is
invoked with a very
* large timeout, close should timeout after request timeout.
*/
- private def checkCloseWithClusterFailure(numRecords: Int, group1: String,
group2: String): Unit = {
+ private def checkCloseWithClusterFailure(numRecords: Int, group1: String,
group2: String,
+ groupProtocol: String): Unit = {
val consumer1 = createConsumerAndReceive(group1, manualAssign = false,
numRecords)
val requestTimeout = 6000
- this.consumerConfig.setProperty(ConsumerConfig.SESSION_TIMEOUT_MS_CONFIG,
"5000")
-
this.consumerConfig.setProperty(ConsumerConfig.HEARTBEAT_INTERVAL_MS_CONFIG,
"1000")
+ if (groupProtocol.equals(GroupProtocol.CLASSIC.name)) {
+
this.consumerConfig.setProperty(ConsumerConfig.SESSION_TIMEOUT_MS_CONFIG,
"5000")
+
this.consumerConfig.setProperty(ConsumerConfig.HEARTBEAT_INTERVAL_MS_CONFIG,
"1000")
+ }
Review Comment:
We should fix this up in a `TestUtils` utility method or something. I've
seen this sprinkled around a couple of different places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
