kirktrue commented on code in PR #18532:
URL: https://github.com/apache/kafka/pull/18532#discussion_r1920913022
##########
core/src/test/scala/integration/kafka/api/ConsumerBounceTest.scala:
##########
@@ -297,12 +302,15 @@ class ConsumerBounceTest extends AbstractConsumerTest
with Logging {
* there is no coordinator, but close should timeout and return. If close is
invoked with a very
* large timeout, close should timeout after request timeout.
*/
- private def checkCloseWithClusterFailure(numRecords: Int, group1: String,
group2: String): Unit = {
+ private def checkCloseWithClusterFailure(numRecords: Int, group1: String,
group2: String,
+ groupProtocol: String): Unit = {
val consumer1 = createConsumerAndReceive(group1, manualAssign = false,
numRecords)
val requestTimeout = 6000
- this.consumerConfig.setProperty(ConsumerConfig.SESSION_TIMEOUT_MS_CONFIG,
"5000")
-
this.consumerConfig.setProperty(ConsumerConfig.HEARTBEAT_INTERVAL_MS_CONFIG,
"1000")
+ if (groupProtocol.equals(GroupProtocol.CLASSIC.name)) {
+
this.consumerConfig.setProperty(ConsumerConfig.SESSION_TIMEOUT_MS_CONFIG,
"5000")
+
this.consumerConfig.setProperty(ConsumerConfig.HEARTBEAT_INTERVAL_MS_CONFIG,
"1000")
+ }
Review Comment:
Or at least a helper method in this test class itself?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
