chia7712 commented on code in PR #18692:
URL: https://github.com/apache/kafka/pull/18692#discussion_r1928557375
##########
core/src/main/scala/kafka/server/KafkaApis.scala:
##########
@@ -911,16 +909,13 @@ class KafkaApis(val requestChannel: RequestChannel,
metadataResponseTopic(Errors.TOPIC_AUTHORIZATION_FAILED, topic,
Uuid.ZERO_UUID, isInternal = false, util.Collections.emptyList()))
}
- // In version 0, we returned an error when brokers with replicas were
unavailable,
- // while in higher versions we simply don't include the broker in the
returned broker list
- val errorUnavailableEndpoints = requestVersion == 0
Review Comment:
Could you please remove unreachable condition in line#902? as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
