jolshan commented on code in PR #18733:
URL: https://github.com/apache/kafka/pull/18733#discussion_r1933043496
##########
core/src/main/scala/kafka/server/ReplicaManager.scala:
##########
@@ -738,12 +738,20 @@ class ReplicaManager(val config: KafkaConfig,
// retry correctly. Translate these to an error which will cause
such clients to retry
// the produce request. We pick `NOT_ENOUGH_REPLICAS` because it
does not trigger a
// metadata refresh.
- case Errors.CONCURRENT_TRANSACTIONS |
- Errors.NETWORK_EXCEPTION |
+ case Errors.NETWORK_EXCEPTION |
Errors.COORDINATOR_LOAD_IN_PROGRESS |
Errors.COORDINATOR_NOT_AVAILABLE |
Errors.NOT_COORDINATOR => Some(new
NotEnoughReplicasException(
s"Unable to verify the partition has been added to the
transaction. Underlying error: ${error.toString}"))
+ case Errors.CONCURRENT_TRANSACTIONS =>
+ if (transactionSupportedOperation != addPartition) {
Review Comment:
I have a PR open that can make this check easier. Depending on what goes in
first, we can modify. 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
