jolshan commented on code in PR #18733:
URL: https://github.com/apache/kafka/pull/18733#discussion_r1933042732
##########
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##########
@@ -115,7 +115,7 @@ class ReplicaManagerTest {
private var mockRemoteLogManager: RemoteLogManager = _
private var addPartitionsToTxnManager: AddPartitionsToTxnManager = _
private var brokerTopicStats: BrokerTopicStats = _
- private val transactionSupportedOperation = genericErrorSupported
+ private var transactionSupportedOperation: TransactionSupportedOperation =
genericErrorSupported
Review Comment:
Is this only used in each test once? If so maybe it doesn't need to be a
global var. If it's just one that uses a variant, we can define it separately
in the test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
