ijuma commented on code in PR #18727:
URL: https://github.com/apache/kafka/pull/18727#discussion_r1936221997
##########
clients/src/main/java/org/apache/kafka/common/protocol/Protocol.java:
##########
@@ -208,26 +208,26 @@ public static String toHtml() {
// Responses
b.append("<b>Responses:</b><br>\n");
Schema[] responses = key.messageType.responseSchemas();
- for (int i = 0; i < responses.length; i++) {
- Schema schema = responses[i];
+ for (int version = key.oldestVersion(); version <
key.latestVersion(); version++) {
Review Comment:
Use the same approach we use for requests for consistency - it should result
in the same behavior, but fail more clearly if there is some inconsistency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
