ijuma commented on PR #18727: URL: https://github.com/apache/kafka/pull/18727#issuecomment-2625968864
@chia7712 @junrao The tests should now be passing for this PR. The comments should also make it clear what's going on. The main point of contention is whether we should remove v0-v2 from the protocol definition files. If we do that, there are three main implications for this PR: 1. The `ApiKeys.oldestVersion` override would no longer be required. 2. The `toApiVersion` code would have to refer to a separate constant for Produce min version (instead of retrieving it from the generated class). 3. We would have to remove `testProduceRequestV0ToV2IsRejectedByBroker` since there would be no way to produce with v0-v2. We would probably have to create a ducktape test to replace that. I am not sure how easy or hard that would be (ducktape tests typically use clients instead of testing specific requests). Given that, I would prefer to keep the current approach to unblock 4.0. I am ok with filing a ticket to do the 3 things listed above, if we prefer that approach. Overall, I think it's a 50/50 situation (neither approach is clearly better than the other), but I am ok if someone else wants to tackle the alternative option. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
