mjsax commented on code in PR #18778:
URL: https://github.com/apache/kafka/pull/18778#discussion_r1940549926
##########
streams/src/main/java/org/apache/kafka/streams/Topology.java:
##########
@@ -476,22 +483,22 @@ public synchronized Topology addSink(final String name,
/**
* See {@link #addSink(String, String, String...)}.
*/
- public synchronized Topology addSink(final String name,
- final String topic,
- final StreamPartitioner<?, ?>
partitioner,
- final String... parentNames) {
+ public synchronized <K, V> Topology addSink(final String name,
+ final String topic,
+ final StreamPartitioner<?
super K, ? super V> partitioner,
Review Comment:
More fixes for generic types that we missed... Similar to
`TopicNameExtractor`.
This also required some more change in internal classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
